search

cascornelissen / svg-spritemap-webpack-plugin

SVG spritemap plugin for webpack
MIT License
207 stars 49 forks source link

Allow adding custom attributes to SVG. #183

Closed jgerigmeyer closed 2 years ago

jgerigmeyer commented 2 years ago

Fixes #182.

cascornelissen commented 2 years ago

@jgerigmeyer, looks good to me! My bad for merging the other PR first, could you rebase this real quick and update the test added in #184?

jgerigmeyer commented 2 years ago

could you rebase this real quick and update the test added in #184?

@cascornelissen Done! ✅

cascornelissen commented 2 years ago

Not entirely I think, GitHub isn't letting me merge it because of conflicts

jgerigmeyer commented 2 years ago

Not entirely I think, GitHub isn't letting me merge it because of conflicts

Really? That's strange... I see:

Screen Shot 2021-11-19 at 2 50 42 PM

cascornelissen commented 2 years ago

I see what happened, you merged master into your branch instead of rebasing it. By default I use the Rebase and merge strategy but that's not available when there's a merge commit in the PR so I'll squash it this time.

jgerigmeyer commented 2 years ago

Ah, my bad -- sorry for the confusion!

cascornelissen commented 2 years ago

No problem at all, and thanks for your contribution! This feature was released as part of 4.4.0 🚀