Closed jgerigmeyer closed 2 years ago
@jgerigmeyer, looks good to me! My bad for merging the other PR first, could you rebase this real quick and update the test added in #184?
could you rebase this real quick and update the test added in #184?
@cascornelissen Done! ✅
Not entirely I think, GitHub isn't letting me merge it because of conflicts
Not entirely I think, GitHub isn't letting me merge it because of conflicts
Really? That's strange... I see:
I see what happened, you merged master
into your branch instead of rebasing it. By default I use the Rebase and merge strategy but that's not available when there's a merge commit in the PR so I'll squash it this time.
Ah, my bad -- sorry for the confusion!
No problem at all, and thanks for your contribution! This feature was released as part of 4.4.0
🚀
Fixes #182.