cascornelissen / svg-spritemap-webpack-plugin

SVG spritemap plugin for webpack
MIT License
207 stars 49 forks source link

Upgrade `svgo@2` to `svgo@3` or `svgo@4`? #214

Open dkrnl opened 2 months ago

dkrnl commented 2 months ago

Description This SVGO@2 is no longer supported.

cascornelissen commented 2 months ago

PRs for this dependency update are welcome, I don't have time myself the coming weeks but depending on the size of the changes I might be able to review a PR ❤️

cascornelissen commented 1 month ago

Looking at the release notes of svgo@3.3.2, it sounds like a v4 release is imminent. Since either v3 or v4 will likely result in a new major release of this plugin as well, I think it makes sense to wait until SVGO v4 is released. There's also a Release Candidate available already so I'd expect this to be available soon™

xavierfoucrier commented 3 weeks ago

Hum, sorry to bother, but I just want to highlight the fact that using svgo@2 and svgo@3 with shared custom configuration between svg-spritemap-webpack-plugin and ImageMinimizerWebpackPlugin can lead to an incompatible state, especially when trying to deal with renamed options, like this one that was renamed in v3: https://svgo.dev/docs/plugins/cleanupIds/.

Waiting for v3/v4 update as well 💯