search

cascremers / scyther

The Scyther Tool for the symbolic analysis of security protocols
https://cispa.saarland/group/cremers/scyther/index.html
96 stars 38 forks source link

Closes #30, enabling builds on Windows under MSYS2 per instructions in Wiki #31

Closed SamJakob closed 1 year ago

SamJakob commented 1 year ago

I just realized I opened this pull request from master and have been working on other fixes, feel free to merge all if desired - anything on my master branch should be fully working. Otherwise, I can open another PR with just the changes for this pull request.

cascremers commented 1 year ago

Hi @SamJakob this looks great, thank you. However, for sanity, it would be great if you can split them into functional PRs, this makes it much easier to review and accept them.

SamJakob commented 1 year ago

32 now has the commits relevant to the original title of the PR. I will close this PR as the final commit, 8a74cc8 had a bit of scope creep as I started fixing other UI/UX issues, so I think I'll make a new PR that fixes Darwin build support and then subsequently another PR for UI/UX which I could work on with a bit more depth.

One thing though - I shall include dark mode support (it's a trivial two-liner that fixes the coloring of the line numbers if wxPython's dark mode setting is True) in the Darwin PR as wxPython automatically supports dark mode on macOS, changing the background and widget colors, and this causes the line numbers to become unreadable. Unless you would prefer otherwise?