search

casdoor / casdoor-dotnet-sdk

.NET client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
28 stars 25 forks source link

fix: fix typo and specified owner in methods that used _options.Organ… #66

Closed d1mak3 closed 1 year ago

casbin-bot commented 1 year ago

@seriouszyx @ComradeProgrammer @Resulte please review

sagilio commented 1 year ago

Hi, May I ask what is different about #65?

d1mak3 commented 1 year ago

Hi, May I ask what is different about #65?

Hello. Nothing much to be honest, just different APIs, because I didn't see this thing in other APIs at first. Should I create new PR with such fix in every API and close this one and #65?

sagilio commented 1 year ago

Hi, May I ask what is different about #65?

Hello. Nothing much to be honest, just different APIs, because I didn't see this thing in other APIs at first. Should I create new PR with such fix in every API and close this one and #65?

I find that #65 includes all changes in this PR. We may merge the #65 and close this PR.

d1mak3 commented 1 year ago

Hi, May I ask what is different about #65?

Hello. Nothing much to be honest, just different APIs, because I didn't see this thing in other APIs at first. Should I create new PR with such fix in every API and close this one and #65?

I find that #65 includes all changes in this PR. We may merge the #65 and close this PR.

My bad, it does include all changes, sorry. So yeah that would be great tyvm

hsluoyz commented 1 year ago

Replaced by: https://github.com/casdoor/casdoor-dotnet-sdk/pull/65