search

casdoor / casdoor-dotnet-sdk

.NET client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
28 stars 25 forks source link

fix: incorrect CasdoorModel and incorrect enforce methods params #72

Closed d1mak3 closed 1 year ago

casbin-bot commented 1 year ago

@seriouszyx @ComradeProgrammer @Resulte please review

hsluoyz commented 1 year ago

@d1mak3 can you please test your code to make sure it works first? Can you provide the test result? Because there are already a lot of PRs, which are fixing the previous PR's bug

d1mak3 commented 1 year ago

@hsluoyz sowwy. It's mostly modifications because I keep forgetting to add something from api. Or in such situation I had old version of casdoor and there was no IsEnabled in Model. But yeah I'll pay more attention sorry once again

hsluoyz commented 1 year ago

@d1mak3 for this time (this PR), have you tested your code to make sure it works locally first? If yes, can you provide the test result?

d1mak3 commented 1 year ago

@hsluoyz hi! This pr contains many mistakes and I decided to fully rewrite it. Can I close this one? And ofc I will attach test results in comments on new pr