search

casdoor / casdoor-go-sdk

Go client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
82 stars 65 forks source link

feat: fix GetPaginationUsers error: "response data format is incorrect" #106

Closed nasa1024 closed 2 months ago

nasa1024 commented 2 months ago

An error message response data format is incorrect appears when using the GetPaginationUsers function with the parameter "groupName": "xx". I have tried to fix it.

Error reproduction steps：

pUsers, count, err := casdoor.Cli.GetPaginationUsers(page, 100, map[string]string{
    "groupName": "xxx",
})
casbin-bot commented 2 months ago

@tangyang9464 @imp2002 please review

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

hsluoyz commented 2 months ago

@nasa1024 why is groupName so special? I didn't see anything wrong in the code.

And why did you do serialization and undo it again? So strange

image

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 0.42.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: