casdoor / casdoor-go-sdk

Go client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
86 stars 70 forks source link

feat: unmarshal data from response model #73

Closed wintbiit closed 1 year ago

wintbiit commented 1 year ago

formatted with gofumpt solved: #71

Need to mention that in casdoor /api/get-sorted-users and /api/get-user-count reponse are not replaced by responseOk. So in sdk I left them unchanged in my commit. Is this already enough or get-sorted-users and get-user-count will be changed later?

casbin-bot commented 1 year ago

@seriouszyx @ComradeProgrammer @Resulte please review

wintbiit commented 1 year ago

replaced #72 because of commit msg error

hsluoyz commented 1 year ago

@WinterOfBit those two functions also need to be wrapped with Response. Fixed by: https://github.com/casdoor/casdoor/commit/516f4b7569b53bd7904db53a67258fceb0a564b5

wintbiit commented 1 year ago

@WinterOfBit those two functions also need to be wrapped with Response. Fixed by: casdoor/casdoor@516f4b7

@hsluoyz added

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 0.26.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: