search

casdoor / casdoor-java-sdk

Java client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
27 stars 43 forks source link

feat: fix get-account API #50

Closed towerhe closed 1 year ago

casbin-bot commented 1 year ago

@seriouszyx @ComradeProgrammer @Resulte please review

codecov[bot] commented 1 year ago

Codecov Report

Merging #50 (969b7e6) into master (bea9ae7) will not change coverage. The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master     #50   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          29      29           
  Lines         892     894    +2     
  Branches       27      27           
======================================
- Misses        892     894    +2
Impacted Files Coverage Δ
.../casbin/casdoor/service/CasdoorAccountService.java 0.00% <0.00%> (ø)
...rg/casbin/casdoor/service/CasdoorEmailService.java 0.00% <0.00%> (ø)
...casbin/casdoor/service/CasdoorEnforcerService.java 0.00% <0.00%> (ø)
...sbin/casdoor/service/CasdoorPermissionService.java 0.00% <0.00%> (ø)
...casbin/casdoor/service/CasdoorResourceService.java 0.00% <0.00%> (ø)
...org/casbin/casdoor/service/CasdoorRoleService.java 0.00% <0.00%> (ø)
...ava/org/casbin/casdoor/service/CasdoorService.java 0.00% <0.00%> (ø)
.../org/casbin/casdoor/service/CasdoorSmsService.java 0.00% <0.00%> (ø)
...rg/casbin/casdoor/service/CasdoorTokenService.java 0.00% <0.00%> (ø)
...org/casbin/casdoor/service/CasdoorUserService.java 0.00% <0.00%> (ø)
... and 1 more
hsluoyz commented 1 year ago

@towerhe plz fix:

image

hsluoyz commented 1 year ago

@WinterOfBit plz review, is this PR duplicated with this one? https://github.com/casdoor/casdoor-java-sdk/pull/48

wintbiit commented 1 year ago

@WinterOfBit plz review, is this PR duplicated with this one? #48

@hsluoyz seems not duplicated. This pr now uses new functions from base class, additionally changed data2 in CasdoorResponse to generic type, added factory test and fixed get-account api. Seem to be fixes and enhancements after #48 . Is that right? @towerhe

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: