search

casdoor / casdoor-java-sdk

Java client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
27 stars 43 forks source link

Refactor using retrofit #52

Closed towerhe closed 1 year ago

casbin-bot commented 1 year ago

@seriouszyx @ComradeProgrammer @Resulte please review

codecov[bot] commented 1 year ago

Codecov Report

Merging #52 (375eb8a) into master (a0d7c8e) will not change coverage. The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master     #52   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          29      23    -6     
  Lines         894     833   -61     
  Branches       27      31    +4     
======================================
+ Misses        894     833   -61
Impacted Files Coverage Δ
...rc/main/java/org/casbin/casdoor/CasdoorClient.java 0.00% <0.00%> (ø)
...java/org/casbin/casdoor/command/SearchCommand.java 0.00% <0.00%> (ø)
...a/org/casbin/casdoor/command/SendEmailCommand.java 0.00% <0.00%> (ø)
...ava/org/casbin/casdoor/command/SendSmsCommand.java 0.00% <0.00%> (ø)
...casdoor/interceptor/AuthenticationInterceptor.java 0.00% <0.00%> (ø)
...or/interceptor/RequireOwnerInQueryInterceptor.java 0.00% <0.00%> (ø)
...casbin/casdoor/response/CasdoorActionResponse.java 0.00% <0.00%> (ø)
...a/org/casbin/casdoor/response/CasdoorResponse.java 0.00% <ø> (ø)
...casbin/casdoor/service/CasdoorEnforcerService.java 0.00% <ø> (ø)
...ava/org/casbin/casdoor/service/CasdoorService.java 0.00% <ø> (ø)
hsluoyz commented 1 year ago

@WinterOfBit plz review

wintbiit commented 1 year ago

@hsluoyz I feel hard to say...... Using retrofit is fancy but makes this project more engineering and java-like, both on codes and project structure. And should be good for further maintenance. This pr refactored not some code pieces, but the whole project, and involved quite a lot api changes, big enough to be casdoor-java-sdk v2 (maybe).

So the thing is to choose between

For me alone, I am slightly more willing to accept the latter and happy to use advanced java features and existing mature libs to make java sdk more modern and cool. What do you and other maintainers think of this?

hsluoyz commented 1 year ago

OK, then we will keep being stable and old-school for now. It's meaningless to seek for fancy for such a SDK.