casdoor / casdoor-java-sdk

Java client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
27 stars 43 forks source link

fix(plan): add missing paymentProviders field and update options data… #92

Closed MonishK2002 closed 1 month ago

MonishK2002 commented 1 month ago

… type

Description

This PR addresses the following issues in the Plan entity of the Java Casdoor SDK:

Changes Made

Related Issue

This PR addresses the mismatch between the Java and Golang implementations regarding the Plan entity.

Please review the changes and let me know if there are any suggestions or concerns.

casbin-bot commented 1 month ago

@tangyang9464 @imp2002 please review

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

MonishK2002 commented 1 month ago

@tangyang9464 Hi Casdoor Team, I have raised a pull request that addresses the following issues in the Plan entity of the Java Casdoor SDK:

    I added the missing paymentProviders field, which is required to match the Golang implementation. This field is defined as a String[] in the Golang code.
   I have updated the data type of the options field to String[], ensuring compatibility with the expected data types in the Golang codebase.
 The pull request has been merged successfully. However, I noticed that the new version including these changes has not been released yet. Could you please release a new version of the Java Casdoor SDK that includes these updates?

Thank you for your assistance and for providing such a valuable tool.

hsluoyz commented 1 month ago

Replaced by: https://github.com/casdoor/casdoor-java-sdk/commit/9361a85e849d38dfe033f017364098459e439e6f