casdoor / casdoor-js-sdk

Javascript client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
30 stars 27 forks source link

feat: add signinPath to SdkConfig #35

Closed xiaocode closed 1 year ago

xiaocode commented 1 year ago

Fix: https://github.com/casdoor/casdoor-js-sdk/issues/34

casbin-bot commented 1 year ago

@seriouszyx @ComradeProgrammer @Resulte please review

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

hsluoyz commented 1 year ago

@xiaocode use the same committer as your github account, and sign CLA

image

codecov[bot] commented 1 year ago

Codecov Report

Merging #35 (30b187f) into master (9bf5e53) will not change coverage. The diff coverage is 0.00%.

:exclamation: Current head 30b187f differs from pull request most recent head c762006. Consider uploading reports for the commit c762006 to get more accurate results

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   11.11%   11.11%           
=======================================
  Files           2        2           
  Lines          54       54           
  Branches       10       13    +3     
=======================================
  Hits            6        6           
  Misses         48       48           
Impacted Files Coverage Δ
src/sdk.ts 7.69% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hsluoyz commented 1 year ago

@xiaocode your committer Email should be added to your GitHub account:

Also refer to: https://casdoor.org/docs/contributing#modify-prs

image

xiaocode commented 1 year ago

@xiaocode your committer Email should be added to your GitHub account:

Also refer to: https://casdoor.org/docs/contributing#modify-prs

image

Done!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 0.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: