search

casdoor / casdoor-php-sdk

PHP client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
18 stars 10 forks source link

feat: fix bug that GetUsers() API doesn't return array #39

Closed i0gan closed 1 year ago

i0gan commented 1 year ago

Fix: https://github.com/casdoor/casdoor-php-sdk/issues/36

In User.php file, getUsers function not returned array object cause fatal error exception.

Fatal error: Uncaught TypeError: Return value of Casdoor\Auth\User::getUsers() must be of the type array, object returned in E:\service\php\vendor\casdoor\casdoor-php-sdk\src\Auth\User.php:310 Stack trace: #0 E:\service\php\OauthTest.php(51): Casdoor\Auth\User::getUsers() #1 E:\service\php\OauthTest.php(84): Casdoor\Tests\testGetUsers() #2 {main} thrown in E:\service\php\vendor\casdoor\casdoor-php-sdk\src\Auth\User.php on line 310

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

casbin-bot commented 1 year ago

@seriouszyx @ComradeProgrammer @Resulte please review

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: