search

casdoor / casdoor-python-sdk

Python client SDK for Casdoor
https://pypi.org/project/casdoor
Apache License 2.0
32 stars 33 forks source link

feat: add auto-release #11

Closed Steve0x2a closed 2 years ago

Steve0x2a commented 2 years ago

Fix: https://github.com/casdoor/casdoor-python-sdk/issues/10

casbin-bot commented 2 years ago

@seriouszyx @Abingcbc @ComradeProgrammer please review

hsluoyz commented 2 years ago

@ffyuanda plz review

ffyuanda commented 2 years ago

@Steve0x2a Please also put the test.pypi.org link here, thanks.

Steve0x2a commented 2 years ago

@Steve0x2a Please also put the test.pypi.org link here, thanks.

@ffyuanda https://test.pypi.org/project/casdoor-python-sdk-test/

ffyuanda commented 2 years ago

@Steve0x2a According to both setuptools and PyPA, we should transition from setup.py to setup.cfg. Are there any reasons that we still need the setup.py file when packaging and distributing?

Steve0x2a commented 2 years ago

@ffyuanda This is because the semantic-release-pypi we use, I tried to just use setup.cfg, but it doesn't work normally. I also tried to use semantic-release-python, but it seems that it has a problem parsing our pyproject.xml:https://github.com/Steve0x2a/test-casdoor-python-ci/runs/5491449127?check_suite_focus=true I thought it might be a good idea to replace an auto-release tool, but I'm not familiar with this.

ffyuanda commented 2 years ago

@Steve0x2a @hsluoyz OK, this PR has fulfilled its mission: add auto-release. If we need a more compatible auto-release tool, we should open another PR. As for now, LGTM.

hsluoyz commented 2 years ago

@ffyuanda @Steve0x2a why the CI doesn't run? Is there anything else we need to do to enable the CI?

https://github.com/casdoor/casdoor-python-sdk/actions

image

ffyuanda commented 2 years ago

@hsluoyz If I'm not mistaken, the CI is configured to be run only n to events: push or pull request, see here https://github.com/casdoor/casdoor-python-sdk/pull/11/files#diff-5c4edb507e52e6e8a1c65945eb84b903c293cdf29ef8194ea316c0dd89d7319eR3-R6

hsluoyz commented 2 years ago

@ffyuanda yes, so this is a PR? Why isn't it triggered? Or should we use a new PR to test?

ffyuanda commented 2 years ago

@hsluoyz Probably we should use a new PR or push to trigger it.

hsluoyz commented 2 years ago

@Steve0x2a can you add a small PR like adding a few texts for README? https://github.com/casdoor/casdoor-python-sdk/issues/7

hsluoyz commented 2 years ago

@leeqvip

leeqvip commented 2 years ago

@hsluoyz I think this PR should be reversed. The configuration directory for Github Actions should be .github/workflows

ffyuanda commented 2 years ago

Agree.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: