search

casdoor / casdoor-python-sdk

Python client SDK for Casdoor
https://pypi.org/project/casdoor
Apache License 2.0
32 stars 33 forks source link

chore: setup.cfg and pyproject.toml added #5

Closed ffyuanda closed 2 years ago

ffyuanda commented 2 years ago

Signed-off-by: ffyuanda shaoxuan.yuan02@gmail.com

casbin-bot commented 2 years ago

@Kininaru please review

ffyuanda commented 2 years ago

@hsluoyz please review

ffyuanda commented 2 years ago

@casbin-bot dude you are a real problem

hsluoyz commented 2 years ago

@ffyuanda any update?

ffyuanda commented 2 years ago

@hsluoyz I guess we need a separate repo for SDK example?

ffyuanda commented 2 years ago

@hsluoyz Updated to use setup.cfg for packaging.

hsluoyz commented 2 years ago

@hsluoyz I guess we need a separate repo for SDK example?

@ffyuanda created: https://github.com/casdoor/casdoor-python-sdk-example please make PR to this repo

hsluoyz commented 2 years ago

@ffyuanda your code is missing setup.py, which is necessary for publishing: https://packaging.python.org/guides/distributing-packages-using-setuptools/

Can you first try to release it to pypi-test: https://test.pypi.org/ with a different name? Like ffyuanda-sdk? And make sure it works?

ffyuanda commented 2 years ago

@hsluoyz I believe now setuptools is trying to transition from setup.py to setup.cfg.

And yeah I will upload it to PyPi test later today to see the result.

hsluoyz commented 2 years ago

@ffyuanda ok, can you give me a guide link to publish with setup.cfg?

ffyuanda commented 2 years ago

@hsluoyz https://test.pypi.org/project/casdoor-sdk/0.0.2/ here is the test.pypi package uploaded. And setuptools has everything about packaging and distributing covered.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: