Remove unsubscribe text

[s-espinosa]

@case-eee Believe this is consistent with the behavior we discussed regarding allowing a user to unsubscribe via text if someone had entered a wrong number, etc.

One note: I found that sending unsubscribe back to these messages triggers something on the Twilio side to not allow the app to send messages to a particular phone number. Twilio still sends that info through to our app in a POST request, so I'm deactivating the users on our side as well, but that may be slightly duplicative. Seems that this functionality is built into Twilio to some degree, but still saves us from attempting to send the daily SMS and gives us an accurate count of active users.

Primary Changes

• Adds /sms route, Sms::BaseController, and Sms::UsersController to handle post requests from Twilio.
• Adds update method to Sms::UsersController to change active to false on a user if they text no or unsubscribe.
• Changes web-based unsubscribe to no longer send a Twilio message.

Secondary Changes

• Removes deactivate method from Twilio service.
• Adds before_save to user to clean incoming phone numbers to be consistent with how Twilio sends them so they can be used in a find_by on the Sms::UsersController.
• Updates message sent on subscribe to tell users how to unsubscribe.
• Adds binding_of_caller gem to dev environment to allow IRB like access on error views.

Questions

• Thoughts on the before_save to clean a phone number on User? Planning to work on a test for this, but wondering if you had any comments.
• Thoughts on the overall structure of having an Sms::BaseController/`Sms::UsersController? Might be overkill, but felt like a familiar way to expose what is essentially an API. Didn't want to mix this functionality with the existing site controllers.
• Any other changes you would make to the Welcome message?

Let me know what you think!

[s-espinosa]

Added tests and refactored Sms::UsersController to avoid deprecation warning.

[s-espinosa]

@case-eee Implemented change to default a user's active status to false.

• Is there any other piece of the app that you think would need to change to accommodate this change?
• Do you have any updated thought on the sms route/controller name? I don't think it'll be terribly difficult to update, but wasn't sure where you came out on that. Let me know! 🎉

[s-espinosa]

@case-eee Adjusted the routes from /sms/users to /messaging/twilio/users per conversation above. Let me know what you think!

[case-eee]

@s-espinosa I think this looks good!