Joke parser - Githubissues

case-eee / kackle

MIT License

1 stars 0 forks source link

Joke parser #8

Closed case-eee closed 7 years ago

case-eee commented 7 years ago

@s-espinosa this PR uses Nokogiri to parse a few html pages i found. it's not perfect yet and i'm not actually doing anything with the parsed data, but this is a start (and might be enough for us to create the MVP). i'm not sure where i want these files to live though. potentially in the db directory? can you think of a better place for them?

s-espinosa commented 7 years ago

@case-eee I like it in db. That totally makes sense to me. Maybe in a subdirectory called sources or html_seeds or something along those lines?

case-eee commented 7 years ago

@s-espinosa awesome 👍

case-eee commented 7 years ago

hey @s-espinosa, i think this is looking good now. major updates:

organized parsing functionality within the db folder
fully cleaned the incoming data (split data into question/answer strings to seed)
created Joke model and migration
added fully functional seed module

let me know what you think 👍

case-eee commented 7 years ago

@s-espinosa thoughts now?