search

caseda / com.tkbhome

TKB Home devices for Homey
5 stars 17 forks source link

Add TZ56-PLUS #67

Open medialica opened 3 years ago

medialica commented 3 years ago

Hi, this is my very first step with GitHub (and Homey too), so I don't know if I'm doing the right things. The scope of this request is to add model TZ56D PLUS (EU) to your Homey driver. So I've basically duplicated "drivers/TZ36" folder into "drivers/TZ56-PLUS" folder and I've changed the productTypeID and productID (driver.compose.json) and some strings accordingly. Please consider that I'm a noob so feel free to do anything you want. Thank you for your great work!

caseda commented 3 years ago

Thank you for your work, looks good at first sight.

Just a question, have you tested the implementation? As TKB doesn't like following the normal z-wave specifications, it is completely possible that your device doesn't work the same as the implementation you have copied over and adapted. As I don't have the device, there is no way for me to fully test this implementation.

medialica commented 3 years ago

Hey,

thank you for your kind reply. I’m sorry but I don’t know how to do a test. I know it is possible to do myself an Homey App (or a modified one) and try it but I never done something like this before.

Let me know if I need to do something to help your work.

Thank you again,

Paolo Bernardini

Il giorno 4 gen 2021, alle ore 01:00, R Mengers notifications@github.com ha scritto:

Thank you for your work, looks good at first sight.

Just a question, have you tested the implementation? As TKB doesn't like following the normal z-wave specifications, it is completely possible that your device doesn't work the same as the implementation you have copied over and adapted.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/caseda/com.tkbhome/pull/67#issuecomment-753695857, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKZ55F4ZQJ5XSTFH2R25K3SYEALRANCNFSM4VSCRENQ.