search

casella / ThermoPower

A Modelica library for thermal power generation system modelling
https://casella.github.io/ThermoPower
36 stars 32 forks source link

Unknown identifiers in Test_Generator_SE* examples #17

Open maltelenz opened 3 years ago

maltelenz commented 3 years ago

The examples in ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE* (and classes they depend on) reference identifiers that do not exist.

These are diagnostic outputs from System Modeler:

[3] 16.46 Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE 
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE [22:11-22:11] Unknown identifier grid.connection.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE [30:13-30:13] Unknown identifier powerConnection.W.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE [29:13-29:13] Unknown identifier powerConnection.f.
[4] 16.48 Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_breaker 
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_breaker [24:11-24:11] Unknown identifier grid.connection.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE_Breaker [31:13-31:13] Unknown identifier powerConnection.W.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE_Breaker [30:13-30:13] Unknown identifier powerConnection.f.
Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_breaker completed with 3 errors.
[5] 16.48 Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_com 
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_com [22:11-22:11] Unknown identifier grid.connection.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE_com [26:13-26:13] Unknown identifier powerConnection.W.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE_com [25:13-25:13] Unknown identifier powerConnection.f.
Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_com completed with 3 errors.
casella commented 3 years ago

The PowerPlants package is in an awkward state. It was devloped many years ago by a former student of mine, then we changed the structure of the Flow1D models, that are used for all heat exchangers, and kept the old Flow1D models as deprecated for backwards compatibility. The idea was to upgrade PowerPlants to the new Flow1D models, this work was started on a branch but I never had time to complete it.

I guess the best idea is to remove PowerPlants from the library and eventually release it separately when the refactoring is complete, I'll try to do that ASAP. For the time being, better not to waste your time on that sub-library

maltelenz commented 3 years ago

For the time being, better not to waste your time on that sub-library

Thank you for that useful information! I'll ignore it for now.