Removed defaultProps. - Githubissues

casesandberg / react-color

:art: Color Pickers from Sketch, Photoshop, Chrome, Github, Twitter & more

http://casesandberg.github.io/react-color/

MIT License

12.05k stars 922 forks source link

Removed defaultProps. #893

Open ofps opened 12 months ago

ofps commented 12 months ago

This PR removes defaultProps from every function component, solving issue #888 . Changes in package.json were needed to successfully build and test the project.

Micode360 commented 11 months ago

I don't know if this was merged with the main branch but Installed this package and got the same error for checkboard and one more. Doesn't seen resolved.

ofps commented 11 months ago

Hi @Micode360

Thank you for your feedback.

If you installed this branch it's possible your version manager kept using the original since the version did not change.

I have successfully removed all warnings from one of my projects by using the main branch of my fork: fernandojpps/react-color, can you see if that works for you?

Let me know if that fixes the warnings for you.

There is another warning with the Checkboard component that this PR doesn't fix, it's related to the use of canvas to generate the checkboard, which only works on the client. I actually tested some solutions for that but I'm not happy with the results yet. That will probably be a future PR.

Micode360 commented 11 months ago

@fernandojpps okay. I ended using another. But if I need it again, I will install it.

fandredev commented 7 months ago

can anyone check this please?

PhamMinhKha commented 6 months ago

This PR removes defaultProps from every function component, solving issue #888 . Changes in package.json were needed to successfully build and test the project. How can I use this update? Could you provide specific guidance to help me? Thank you very much.