search

casework / CASE-Implementation-UFED-XML

Apache License 2.0
8 stars 1 forks source link

Add CI for CASE validation #2

Closed kchason closed 1 year ago

kchason commented 1 year ago

Related to #1, this adds CASE validation to the /json directory via a GitHub Action and provides the setup for a CI pipeline that can be expanded as the repository.

ajnelson-nist commented 1 year ago

I've run a catch-up merge to trigger CI on the updated main state.

fabrizio-turchi commented 1 year ago

I deleted the old JSON files and generated new ones, complied with the validation process

ajnelson-nist commented 1 year ago

@fabrizio-turchi - I suggest this pull request be merged rather than closed. This repository is in need of a review mechanism for its generated output.

The new example files you generated have some typos that make them non CASE 1.0.0 content, and in a few cases non-functional RDF triples. Lines 23--25 here are not attached to any object, so they would be dropped in any load of this file as JSON-LD. They should probably be attached to a case-investigation:Investigation object. Line 26 in that same file also turns the file into a "quads" ("quadruples") graph rather than a "triples" graph. I don't think CASE has any issue with this ,but we aren't currently supporting quad technologies.

Line 30 on that file shows another issue that a CASE typo checker needs to review. The class name to use is not ObjectObservable (romance-languages' grammatical style), it's ObservableObject (English grammatical style).

I request you merge this PR. I'm pushing a catch-up merge 89e8f59 now.