search

casework / CASE-Mapping-Python

Apache License 2.0
0 stars 3 forks source link

Add and confirm prefix customization; start doctests #39

Closed ajnelson-nist closed 7 months ago

ajnelson-nist commented 7 months ago

This patch series is an isolated and expanded change drawn from PR 38.

This patch series was written to integrate into the current class hierarchy without disruption to existing code. This patch does not necessarily indicate agreement with the current class hierarchy.

ajnelson-nist commented 7 months ago

I think a future change will need to adjust how the prefix label and IRI is determined. The top-level graph dictionary might need to be handled externally to the class hierarchy currently rooted in FacetEntity, e.g., so a non-default prefix_label can be used without needing to pepper it throughout the caller's code.

ajnelson-nist commented 7 months ago

Also, this test adds an additional target to make check that is not yet repeated by the CI. I believe the test is worth running to prevent developer information leakage: file paths are potentially embeddable in data from Turtle generated from JSON-LD that supplies neither node prefixes nor a @base context dictionary directive.

ajnelson-nist commented 7 months ago

Also, this test adds an additional target to make check that is not yet repeated by the CI.

Test has been added.

ajnelson-nist commented 7 months ago

This PR is ready for review and merge.