search

casework / CASE-Mapping-Python

Apache License 2.0
0 stars 3 forks source link

Fix #8 issue, changing ProvenanceRecord #48

Closed fabrizio-turchi closed 4 months ago

fabrizio-turchi commented 4 months ago

In the ProvenanceRecord class definition I defined the uco_core_objects parameter as follows

uco_core_objects: Union[None, Dict, List[Dict]] = None

instead of

uco_core_objects: Union[None, ObservableObject, List[ObservableObject]] = None

perhaps it can be defined considering that it will contain ObservableObjects?

ajnelson-nist commented 4 months ago

In the ProvenanceRecord class definition I defined the uco_core_objects parameter as follows

uco_core_objects: Union[None, Dict, List[Dict]] = None

instead of

uco_core_objects: Union[None, ObservableObject, List[ObservableObject]] = None

perhaps it can be defined considering that it will contain ObservableObjects?

You were right to check on this - we had decided to not use plain Dicts in PR #46.

However, the ontology requires these be UcoObjects, not the more-specific ObservableObjects. I've pushed a patch implementing this.