search

casework / CASE-Mapping-Python

Apache License 2.0
0 stars 3 forks source link

Fix #9 issue, changing FileFacet class #49

Closed fabrizio-turchi closed 4 months ago

fabrizio-turchi commented 4 months ago

To be coherent should I define a type checking also for the dates? I left the code as it was by using the file_xxx_time=None as follows:

def __init__(
        self,
        file_accessed_time=None,
        ...
        file_metadata_changed_time=None,
        file_modified_time=None,
        file_created_time=None,
    ):
fabrizio-turchi commented 4 months ago

Why did CI fail (again)? DO I have to better check my code to avoid the nuisance (to you)? Please let me know...

ajnelson-nist commented 4 months ago

It's no nuisance.

Logistics check: Are you able to see the CI logs seeing "Details" by the red X's?

You can reproduce the CI failures in your local environment by running make check. There is a Makefile in this project that mimics what CI does. You should be able to see that this is the same issue stemming from PEP 484 on the last PR.

fabrizio-turchi commented 4 months ago

Thanks! I'll try to fix the issue and push it again

fabrizio-turchi commented 4 months ago

@ajnelson-nist : this time everything went well, thanks again for your support!