search

casework / CASE-Mapping-Python

Apache License 2.0
0 stars 3 forks source link

Fix #11 issue, changing LatLongCoordinatesFacet class #53

Closed fabrizio-turchi closed 3 months ago

fabrizio-turchi commented 3 months ago

@ajnelson-nist I changed also the WirelessNetworkConnectionFacet class and even though the case_validate went well, I'm not completely sure of the definition of the wirelessNetworkSecurityMode: the global range is owl:Thing but the OWL definition is vocabulary:WirelessNetworkSecurityModeVocab xsd:string.

ajnelson-nist commented 3 months ago

@ajnelson-nist I changed also the WirelessNetworkConnectionFacet class and even though the case_validate went well, I'm not completely sure of the definition of the wirelessNetworkSecurityMode: the global range is owl:Thing but the OWL definition is vocabulary:WirelessNetworkSecurityModeVocab xsd:string.

Where did you see owl:Thing as the global range of observable:wirelessNetworkSecurityMode? The definition I see is here in UCO 1.3.0.

With what I see of the regenerated JSON-LD, your patch is fine as-is, so I'll merge it now. Please feel free to ask follow-up questions here.