casework / CASE

Cyber-investigation Analysis Standard Expression (CASE) Ontology
https://caseontology.org
Apache License 2.0
67 stars 22 forks source link

Ont 413 #42

Closed ajnelson-nist closed 3 years ago

ajnelson-nist commented 3 years ago

I recommend PR 41 be merged first.

ajnelson-nist commented 3 years ago

@plbt5 I've fixed the merge conflict. This is ready for your review.

ajnelson-nist commented 3 years ago

I added a merge commit to address the ChangeLog conflict and update the merge to today. The material to review is otherwise unchanged, @plbt5 .

ajnelson-nist commented 3 years ago

Sorry! I missed you reviewed.

plbt5 commented 3 years ago

haha, we're workng against each other now :-)

ajnelson-nist commented 3 years ago

Re:

I have not validated consistency with imported ontology in that all prefixed concepts actually exist. I assume this to be part of the regression test. Yes, these tests exist, though in the CASE-Examples-QC repository. There is an automated test there to confirm referenced concepts exist in instance data. The test was not a committee-approved mechanism, but it has assisted with all examples' quality control to date. These tests will be incorporating the recently-released UCO-Utility-Pre-0.6.0-Validator.