Updated syntax surrounding ExaminerActionLifecycle.

casework / CASE

Cyber-investigation Analysis Standard Expression (CASE) Ontology

https://caseontology.org

Apache License 2.0

65 stars 22 forks source link

Updated syntax surrounding ExaminerActionLifecycle. #69

Closed regriff closed 2 years ago

regriff commented 2 years ago

Review steps taken:

Tracking in Jira ticket ONT-465
[x] Pull request is against correct branch
[x] CI passes in (CASE/UCO) feature branch
[x] CI passes in (CASE/UCO) current unstable branch (merge-commit with CI included)
[x] Impact on SHACL validation reviewed for CASE-Examples
[x] Impact on SHACL validation remediated for CASE-Examples (N/A)
[x] Impact on SHACL validation reviewed for casework.github.io
[x] Impact on SHACL validation remediated for casework.github.io (N/A)

ajnelson-nist commented 2 years ago

@plbt5 , with the citation style in that comment, I do not think there is potential for confusion. The term "Re-implement" was also selected to indicate as strongly as possible that the concepts are intended to behave like the same-named concepts in PROV-O. I forget if you were present for those concepts' definition in CASE, but we did not want to cause entailments (yet) from importing a portion of PROV-O, which is why we chose to re-implement rather than import.

If you have further concerns with those concepts, let's please discuss them in a new Jira ticket, as they are out of scope of this proposal.

ajnelson-nist commented 2 years ago

I've re-titled the PR to note that we should wait for the proposal to be announced.

ajnelson-nist commented 2 years ago

Oh, and after the PR is announced, can we please add a line to the ChangeLog for this before merging?

ajnelson-nist commented 2 years ago

@plbt5 : In my opinion, this is a bugfix proposal that does not require committee review. If you agree, please feel free to merge.