casework / CASE

Cyber-investigation Analysis Standard Expression (CASE) Ontology
https://caseontology.org
Apache License 2.0
65 stars 22 forks source link

(UCO Issue 373) Upgrade rdf-toolkit and Java #90

Closed ajnelson-nist closed 2 years ago

ajnelson-nist commented 2 years ago

This Pull Request is part of resolving UCO Issue #373.

This PR is a little out of the normal, ontology-scoped review form, because of a shared technology issue. UCO and CASE both use rdf-toolkit.jar to handle normalizing Turtle data. The upgrade in UCO Issue 373 will upgrade Java and rdf-toolkit.jar to a state that will be incompatible with the version of Java and rdf-toolkit.jar that CASE has "pinned" for its CI.

Hence, the patches in this PR handle two issues:

  1. Delegating to UCO handling of rdf-toolkit.jar retrieval.
  2. Upgrading CASE to also use Java 11.

Review steps taken:

ajnelson-nist commented 2 years ago

In Dutch, we use the abbreviation GB when we don't find any peculiarities worth mentioning. How would that translate in English?

LGTM, "Looks Good To Me," is probably closest.