search

casey-c / FilterTheSpire

Customize your Slay the Spire experience
MIT License
4 stars 3 forks source link

Add shop relic filter #5

Closed beeyee0401 closed 3 years ago

beeyee0401 commented 3 years ago

This commit adds the Shop relic option for those who want an early Prismatic shard, Membership Card, or Orange Pellets in the first shop.

This filter works by itself, but I did not test it in conjunction with the Boss Swap, because theoretically you should be able to have both Filters on. I did not test it because I do not know how to really build the menu in such a way where it can toggle between Boss Swap menu and Shop relic menu.

Merging this as is should not change the functionality of the mod at the moment, since it's not being used from the menu until another commit is made to add it. Feel free to share the code between BossSwapFilterScreen and ShopRelicFilterScreen, there are very few differences between them.

casey-c commented 3 years ago

Hi! Thank you for the commits - this is excellent stuff! I took a brief look through it right now on Github and it seems ready to merge without issue.

I'll set some time aside this weekend just to pull it locally and verify everything builds okay - and then I'll merge it in.

Do you have a desired username that you'd like to be credited as in the ModTheSpire author_list? I can add your name to this file (which is metadata that shows up for users of the mod) after merging if you let me know your preferred credit.

https://github.com/casey-c/FilterTheSpire/blob/main/src/main/resources/ModTheSpire.json

Thanks again for the merge request!

beeyee0401 commented 3 years ago

beeyee would be great as a credit, thanks! And again, I never implemented the config menu stuff completely, so sorry for not doing it 100%. I'm just not experienced with that part of modding.

casey-c commented 3 years ago

I'm so sorry this took so long. I really appreciate your efforts here, and I feel really bad that it slipped my mind entirely :( I think something must have come up during the weekend where I meant to look into it more and just totally forgot to write it down to remind myself. We'll get that UI stuff sorted out with the next update. Working on finishing up my InfoMod for the workshop and I have one other teeny tiny side project and then I want to get back to FilterTheSpire again - I have some fresh ideas by now I think, and getting your contributions and Ian's into the full frontend mix for use is something pretty high priority for me!