search

casey / just

🤖 Just a command runner
https://just.systems
Creative Commons Zero v1.0 Universal
20.25k stars 451 forks source link

GitHub Linguist Syntax Bug #1626

Open macintacos opened 1 year ago

macintacos commented 1 year ago

Please ref the discussion I opened here: https://github.com/github-linguist/linguist/discussions/6401#discussion-5157240. There is an issue with the just syntax for multi-line strings that I am hoping can be fixed, as it makes several of my justfiles to be almost no better than just plaintext files 😅

In this comment, I noticed that the repo that the linguist file is pointing to is archived. It should likely be updated to something else, perhaps a grammar maintained in this repository itself?

tgross35 commented 8 months ago

I mentioned it there, but I am working on getting the tree-sitter syntax working better: https://github.com/IndianBoy42/tree-sitter-just. I think GH should be able to use this.

nk9 commented 4 months ago

Unfortunately, GitHub Linguist only supports the venerable TextMate format. I have updated the syntax highlighting to use SublimeText format in the just_sublime package, but that isn't supported by GitHub at present either.

While it won't help you on GitHub, it's perhaps interesting to note that multiline strings work fine in the rewritten Sublime syntax, and (I belive) also in the vim-just syntax.

tgross35 commented 4 months ago

GH does apparently support tree-sitter grammars for some languages, sounds like it just isn't very public according to https://github.com/github-linguist/linguist/discussions/6073. So I did what is suggested there and opened a discussion at https://github.com/orgs/community/discussions/116733, guess we will see if it goes anywhere...

nk9 commented 4 months ago

Wow, TIL! Good to see that they're expanding the sorts of grammars they're supporting.