casey / just

🤖 Just a command runner
https://just.systems
Creative Commons Zero v1.0 Universal
17.6k stars 399 forks source link

Cargo.toml dependencies need cleanup? #1995

Open laniakea64 opened 1 month ago

laniakea64 commented 1 month ago

During recent research for vim-just I ran across this - https://deps.rs/crate/just

Where couple things jumped out:

1) just's dependency on regex states version 1.5.4, which the deps.rs link flags as a security vulnerability. However, just is actually using regex version 1.10.3 - https://github.com/casey/just/blob/c237c0097b50f669f5607a15feafcf1fd6ce40c1/Cargo.lock#L715-L718 Should this be updated in Cargo.toml to prevent false positives?

2) just declares a development dependency on yaml-rust, which is unmaintained. AFAICT this dependency is completely unused in today's just code, seems its use was removed in https://github.com/casey/just/commit/bb5b962c3dbcf0dc8258e50844602f1f5080f00c ?