search

caseyamcl / phpoaipmh

OAI-PMH client/harvester library for PHP
MIT License
75 stars 35 forks source link

Replace references to `DateTime` with `DateTimeInterface` #49

Closed caseyamcl closed 6 years ago

caseyamcl commented 6 years ago

We still (unofficially) support PHP v5.4 in Version 2.x of phpoaipmh, but will not do so in v3.

At that point, we can replace all references to DateTime with DateTimeInterface, which became available in PHP v5.5.

rudolfbyker commented 6 years ago

This would be fantastic, since I'm using DateTimeImmutable instead of DateTime, which gives me incorrect "Deprecated" errors. The createRecordIterator function seems to assume that anything that is not \DateTime is a string.

caseyamcl commented 6 years ago

Hi @rudolfbyker .. This is resolved in v3. Release notes Enjoy!

rudolfbyker commented 6 years ago

Awesome, thanks!

On Wed, 17 Oct 2018 at 16:05, Casey McLaughlin notifications@github.com wrote:

Hi @rudolfbyker https://github.com/rudolfbyker .. This is resolved in v3. Release notes https://github.com/caseyamcl/phpoaipmh/releases/tag/v3.0 Enjoy!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/caseyamcl/phpoaipmh/issues/49#issuecomment-430642057, or mute the thread https://github.com/notifications/unsubscribe-auth/AJj5fvQJF4_KMgYT_bi1mPrGe7qsZsTqks5ulzkhgaJpZM4Sg7nc .