search

caseycrogers / flutter_gutter

MIT License
15 stars 3 forks source link

To many exception when All Exceptions breakpoint is active. #3

Closed 2shrestha22 closed 1 month ago

2shrestha22 commented 1 month ago

Previously you were checking if a widget is flex or not but after dynamic check gutter gives too many exceptions. Is there any reason for dynamic checking?

The change that is throwing error. https://github.com/caseycrogers/flutter_gutter/blame/4c8eacff77d8726b69e9782a1adea0d10d5a2860/lib/src/gap.dart#L46-L52

caseycrogers commented 1 month ago

Hello, I made the change in order to support widgets that were provided by other packages (namely BoxyRow and BoxyColumn).

Here's a Flutter issue where I discuss the need and some potential solutions that Flutter could implement to avoid the dynamic check: https://github.com/flutter/flutter/issues/133394

How about, in the meantime, I include a static bool flag that you can set to turn on or off the dynamic checking behavior? If off it'll behave just like it used to?

2shrestha22 commented 1 month ago

That seems like a good idea. And I think that the gutter has gap as a dependency but it has never been used.

caseycrogers commented 1 month ago

Oh man good catch, I was testing migrating to using gap internally but rolled it back, I guess not cleanly.

Expect a new release tonight or tomorrow with these two fixes.

2shrestha22 commented 1 month ago

Thanks, I am ready to upgrade.

caseycrogers commented 1 month ago

I just put out an update that should resolve these. Let me know if you have any issues with it or further feature requests!