Improvements and Tests - Githubissues

caseycrogers / flutter_gutter

MIT License

15 stars 3 forks source link

Improvements and Tests #6

Closed martijn00 closed 1 month ago

martijn00 commented 1 month ago

Connection with issue(s)

Connected to #4

Solution description

Screenshots or Videos

To Do

[x] Check the original issue to confirm it is fully satisfied
[x] Add solution description to help guide reviewers
[x] Add unit test to verify new or fixed behavior
[x] If apply, add documentation to code properties and package readme

caseycrogers commented 1 month ago

Will wait on release! Just lmk when this is ready for merge and we're ready for launch

Though heads up I'm leaving for a ~6 day camping trip in 4 hours so it'll be awhile before I get back to this

martijn00 commented 1 month ago

@caseycrogers Done! I'll open a new PR if i find anything but this should be good to merge and release.

martijn00 commented 1 month ago

@caseycrogers Done

martijn00 commented 1 month ago

@caseycrogers if you have some time when you are back can we look at getting this merged?

I'm also making some PRs to flutter adaptive scaffold itself to make some checks in here easier.

martijn00 commented 1 month ago

I've tried to accommodate your change requests. I really don't think rolling back to the GutterTiny etc and Gap is a good idea. Rather move forward and go to a RenderBox.

martijn00 commented 1 month ago

I've made https://github.com/flutter/packages/pull/7300 here you can see the usage of multi constructors as well: https://github.com/flutter/packages/pull/7300/files#diff-8399b95990f0c1ed9192ac5d83957d04277e6d3b8b5add66bed1bb43b608f9e9R119

After https://github.com/flutter/packages/pull/7347 is merged I'll make a PR to update gutter to use it as well.

I'll also open some PR's to the adaptive package to add official sizes for the gap, hopefully that lands sometime soon.

It's ok if you prefer multiple widget, but i've made both ways possible right now, so why not leave both ways in?