caseydavenport / biermacht

Homebrewer's Companion for Android
Apache License 2.0
23 stars 10 forks source link

Feature Request: Consolidate multiple ingredient additions #31

Open paulswanson opened 8 years ago

paulswanson commented 8 years ago

I'd like to humbly propose an alternate approach for viewing / organising multiple additions of individual ingredients. Most brewing apps / software treat each addition of a single ingredient as a separate ingredient, although practical, I'd argue this reduces the overall readability of ingredients lists.

The typical example is hop additions. In an IPA one might use 3 hops, but in Biermacht each addition is treated as a separate ingredient. This makes sense as a "recipe" but I'd argue not as an "ingredients" list. I'd argue an ingredients list should look like what one might expect to find on a bottle label and not a recipe card, for example:

3kg Pale Malt, 30g Cascade, 30g Simcoe, 30g Galaxy

...and not

3kg Pale Malt, 10g Cascade (60min), 10g Simcoe (10min), 10g Cascade (10min), 10g Galaxy (10min), 10g Cascade (Whirlpool), 20g Simcoe (Whirlpool), 20g Galaxy (Whirlpool).

So, one suggestion could be that when editing the single hop ingredient, a separate tab could be presented that allows hop additions to worked out, there by updating the overall recipe. In this, or any similar scenario, the ingredients list would reflect the individual ingredients used increasing readability when scanning recipes.

On the ingredients list, multiple additions could even be subtly indicated with small, subtitled 'additions indicators' of some sort. For example:

Cascade 30g (60m, 10m, W)

or

Cascade 30g (10g @ 60m, 10g @ 10m, 10g @ W)

Casey, great work on your app. It's the type of Android brewing I've been looking for. I'd possibly be interested in contributing to development if this approach is of interest to you. Cheers!

paulswanson commented 8 years ago

One final thought, this approach would make it simpler when working out different hopping regimes for a given recipe.

caseydavenport commented 8 years ago

Hey Paul - thanks for the proposal. I see where you're coming from regarding recipe vs ingredient list, and definitely see the value in adding the ability to view / modify recipes in this way.

I'll put some thought into this (I'm on vacation at the moment) but at first glance, the key point about implementing this would be to make sure that the UI is unobtrusive, and doesn't add an extra steps for those who want to keep using Biermacht with the "recipe" style ingredient viewer.

Maybe we want to add a toggle to the ingredients viewer (or globally?) which combines all instances of the same ingredient in the UI?

caseydavenport commented 8 years ago

This might overlap with #29 as well, so worth thinking about how they fit together.