Passing brightness as a string doesn't work

caseyjhol / node-red-contrib-tplink

A collection of Node-RED nodes for TP-Link Smart Home devices

https://www.npmjs.com/package/node-red-contrib-tplink-iot

MIT License

16 stars 15 forks source link

Passing brightness as a string doesn't work #11

Closed caseyjhol closed 4 years ago

MaddyTP commented 4 years ago

Identified a fix for this issue...will have a new PR today.

caseyjhol commented 4 years ago

After testing v0.2.1, it looks like setting brightness as a string didn't work then either. Apparently I never implemented it. Could've sworn I did (especially since I put it in the docs).

MaddyTP commented 4 years ago

It wouldn't be difficult to implement, but it would be more reliable to set int values through properties since there are many.

Hue/Temperature/Brightness/Saturation...

caseyjhol commented 4 years ago

Yea, might be more work than it's worth. I'm thinking we just remove the mention from the docs.

MaddyTP commented 4 years ago

Completely agree...it would be difficult to determine which property was being changed without the property.