search

caseyjhol / node-red-contrib-tplink

A collection of Node-RED nodes for TP-Link Smart Home devices
https://www.npmjs.com/package/node-red-contrib-tplink-iot
MIT License
16 stars 15 forks source link

Full Rework #25

Closed hufftheweevil closed 4 years ago

hufftheweevil commented 4 years ago

See https://github.com/caseyjhol/node-red-contrib-tplink/issues/23 for more info

caseyjhol commented 4 years ago

A small thing, but I wonder if we should change the name of the node to kasa instead of tplink? It seems TP-Link has removed their branding from the Kasa site: https://www.kasasmart.com. Open to suggestions of course.

hufftheweevil commented 4 years ago

I've got nothing against that

caseyjhol commented 4 years ago

Getting an error with my HS220 - "TypeError: node.newDevice is not a function". node.newDevice isn't defined anywhere.

hufftheweevil commented 4 years ago

Whoops - I had done some last minute changes and forgot to do a full test. See PR https://github.com/caseyjhol/node-red-contrib-tplink/pull/26