search

caseyjhol / node-red-contrib-tplink

A collection of Node-RED nodes for TP-Link Smart Home devices
https://www.npmjs.com/package/node-red-contrib-tplink-iot
MIT License
16 stars 15 forks source link

Cannot set connection and event poll interval to 0 #36

Closed kozmoz closed 4 years ago

kozmoz commented 4 years ago

Describe the bug Cannot set both the connection poll interval and the event poll interval to 0 to disable it. When saved, it says those fields are required. It's mentioned in the README.md that 0 disables polling.

To Reproduce Steps to reproduce the behavior:

  1. Create new tplink node
  2. Select just a random device
  3. Set connection poll interval to 0
  4. Set event poll interval to 0
  5. Click save and see the error

Expected behavior Should save the 0 values without showing an error

Desktop:

Additional context There's no way to disable polling

hufftheweevil commented 4 years ago

Please upgrade to v1.0.0-alpha.1

@caseyjhol: Should we make it into a release now? Seems that many are missing the alpha because it's not the latest release.

kozmoz commented 4 years ago

Yes now it works. I wasn’t aware the Readme is for the development version.

Only minor issue is that the existing nodes didn’t exist anymore. Isn’t there a way to convert those nodes automatically. But everything is working fine now! 👍🏻

hufftheweevil commented 4 years ago

Unfortunately not. The node types are different.

caseyjhol commented 4 years ago

@hufftheweevil We probably should. I was just worried about breaking anybody's config.