Azzaare commented 3 years ago

This is an attempt to clean and reorganize the code (according to the “chaotic” state mentioned in the README.md)

I try to follow the bluestyle guideline at the same time, but this is just a personal taste. Please notify me if you don't like some changes @caseykneale (to be honest, it is kind of an excuse for me to read all the code …)

codecov-commenter commented 3 years ago

Codecov Report

Merging #28 (65dbca8) into master (78819ed) will increase coverage by 0.42%. The diff coverage is 7.14%.

@@            Coverage Diff            @@
##           master     #28      +/-   ##
=========================================
+ Coverage    8.90%   9.33%   +0.42%     
=========================================
  Files           4       3       -1     
  Lines         146     150       +4     
=========================================
+ Hits           13      14       +1     
- Misses        133     136       +3

Impacted Files	Coverage Δ
src/visualizations.jl	`0.00% <0.00%> (ø)`
src/types.jl	`2.50% <2.50%> (ø)`
src/utilities.jl	`41.93% <42.85%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78819ed...65dbca8. Read the comment docs.

Azzaare commented 3 years ago

This is good to go. My tests on the UI show no changes.

Once that PR is merged, I can really start to work on making improvement to Sherlock :D

caseykneale / Sherlock.jl

Reshape the code organisation #28

Codecov Report