search

caseywatts / ember-cli-mirage-faker-codemod

2 stars 2 forks source link

Update transform to use default export from faker #7

Closed samselikoff closed 4 years ago

samselikoff commented 5 years ago

I think faker has changed some of its organization since this was originally written, and now the default export is the faker library.

The extra config for auto import is also not needed.

themmer commented 4 years ago

Thanks @samselikoff @caseywatts for being super smart! For now, I am just going to use the raw transform.js directly from this pr. I was able to remove my blocker of faker (love it too much) not importing. It would be nice to merge this to make the 1.0 beta.1 ec-mirage release notes valid. I use faker and mirage to make high fidelity prototypes in Ember :D

samselikoff commented 4 years ago

@themmer Good call. I'll move it under the miragejs org (and be sure to credit casey!) so there's no confusion.

samselikoff commented 4 years ago

@themmer Ok, new repo up + Upgrade guide has been updated: https://github.com/miragejs/ember-cli-mirage-faker-codemod

Thanks for chiming in on this :)