search

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 67 forks source link

Update workflow with macOS 11 #104

Closed alcivanio closed 1 year ago

alcivanio commented 1 year ago

Update workflow with macOS 11

alcivanio commented 1 year ago

This patch is to update the os version our ci will run. A few other files needed to be update, things such as devices sizes, some frameworks versions where also updated.

gonzaloperretti commented 1 year ago

Hi, any news regarding this?

NickEntin commented 1 year ago

This is missing a bunch of file deletions... we've added reference images for 14.5 and 13.7, but haven't deleted the old ones for 14.2 and 13.3. It also still contains a bunch of reference images for iOS 15 that we shouldn't add yet.

I spent way too long trying to figure out why Git wasn't able to figure out a lot of these were renames before I realized that was the issue. 😂 In any case, ended up with #107.

NickEntin commented 1 year ago

At a higher level, this PR is getting quite large. From what I can tell, there's at least X distinct tasks here:

  1. Update iOS 13 snapshots from iOS 13.3 to 13.7.
  2. Update iOS 14 snapshots from iOS 14.2 to 14.5.
  3. Introduce comparison tolerances.
  4. Update the CI runner from macOS-10.15 to macOS-11 and associated gem/action dependencies.
  5. Change sample project dependencies to use SnapshotTesting 1.9 instead of 1.7.2.

Unfortunately the runners don't overlap nicely, so 2 and 4 are tied together, but I think it would be a lot cleaner to move 1 and 3 (and maybe 5) to separate PRs. Especially 3 since it's a bit of a complicated topic (see #63).