Improve layout of snapshot container for super wide views

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility

Apache License 2.0

544 stars 69 forks source link

Improve layout of snapshot container for super wide views #11

Closed NickEntin closed 2 years ago

NickEntin commented 4 years ago

We currently show a single column legend for wide views. When a view gets wide enough (as seen in this snapshot) we could split the legend into multiple columns, to avoid having so much empty space in the snapshot image.

This could potentially cause some issues with wrapping, resulting in messy diffs, but I think the benefits in reduced snapshot size might be worth it. Curious if anyone has thoughts on this.

NickEntin commented 2 years ago

This has been open for over a year and in practice hasn't been a significant issue. I'm going to close this out as a won't-fix for now, but happy to reopen if this becomes more of an issue in the future.