search

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
534 stars 65 forks source link

Fix issue where text entry do not have "text field" or a hint in the description #186

Closed DavidBrunow closed 4 months ago

DavidBrunow commented 5 months ago

Fixes #57. Takes over from #58.

DavidBrunow commented 5 months ago

@NickEntin do you need anything from me on this? I want to make sure I'm not blocking anything 😄

NickEntin commented 4 months ago

@DavidBrunow Apologies, been a hectic couple weeks. I'll go ahead and update the snapshot images for you.

NickEntin commented 4 months ago

Ahh looks like the snapshots are flaky cause of the cursor flashing. I think we need to figure out #15 before we land this one. 😕

NickEntin commented 4 months ago

I think we need to figure out https://github.com/cashapp/AccessibilitySnapshot/issues/15 before we land this one.

206 should resolve this.

DavidBrunow commented 4 months ago

@DavidBrunow Apologies, been a hectic couple weeks. I'll go ahead and update the snapshot images for you.

Not a problem and I'm not trying to add pressure, just wanted to make sure there wasn't more I could do 😄

NickEntin commented 4 months ago

I think if you rebase this on main the builds should pass now 🤞

DavidBrunow commented 4 months ago

I think if you rebase this on main the builds should pass now 🤞

This is done.

DavidBrunow commented 4 months ago

I think if you rebase this on main the builds should pass now 🤞

This is done.

~I did not recapture the snapshots 🤦. I'll do that now, hopefully my machine will capture them right.~

Actually I'm going to wait on this since you've mentioned needing to capture them on build machines in the past. Let me know if I need to take any action on this.

NickEntin commented 4 months ago

Ahh yeah, let me pull the images from the CI jobs and update it now. I don't think the iOS 16 job should have failed, so maybe a different problem... 🤔

DavidBrunow commented 4 months ago

Ahh yeah, let me pull the images from the CI jobs and update it now. I don't think the iOS 16 job should have failed, so maybe a different problem... 🤔

All checks have passed ✅ 🎉

NickEntin commented 4 months ago

Thanks David, this looks great! I'll do one final pass to make sure we're good to merge.

One last thing: have you signed the contributor license agreement?

DavidBrunow commented 4 months ago

Thanks David, this looks great! I'll do one final pass to make sure we're good to merge.

One last thing: have you signed the contributor license agreement?

I have not, working on that now.

DavidBrunow commented 4 months ago

Thanks David, this looks great! I'll do one final pass to make sure we're good to merge.

One last thing: have you signed the contributor license agreement?

FYI I will not get this done tonight, checking with folks at work to ensure there are no issues.

DavidBrunow commented 4 months ago

Thanks David, this looks great! I'll do one final pass to make sure we're good to merge. One last thing: have you signed the contributor license agreement?

FYI I will not get this done tonight, checking with folks at work to ensure there are no issues.

@NickEntin I have signed the contributor license agreement.