search

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 69 forks source link

Bump minimum supported iOS version to 12.0 #27

Closed NickEntin closed 3 years ago

NickEntin commented 3 years ago

Resolves #25.

NickEntin commented 3 years ago

Realized there were a fair number of availability checks for iOS 11 that can be removed now. Addressed in 54c645d.

NickEntin commented 3 years ago

No idea why that CI build had some differences in the iOS 13 snapshots the first time.

testTabBars()
- Item B: 3 items. Tab. 2 of 4.
+ Item B. Tab. 2 of 4.
- Item C: A. Tab. 3 of 4.
+ Item C. Tab. 3 of 4.

testStepper()
- Decrement. Button.
+ minus. Button.
- Increment. Button.
+ plus. Button.

testStepperAtMin()
- Decrement. Dimmed. Button.
+ minus. Dimmed. Button.
- Increment. Button.
+ plus. Button.

Kicking off a new build fixed it though. Same environment as far as I can tell. And everything seems to be working locally. 🤷‍♂️

I'm gonna call that a weird flake and move forward with this. I'll keep an eye on it and see if any more fail like this going forward though.