search

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 69 forks source link

Replace dependency on fishhook with inlined code #42

Closed NickEntin closed 3 years ago

NickEntin commented 3 years ago

Fishhook is currently blocking SPM support (#1) and hasn't been merging PRs recently, so it looks like that support likely isn't coming soon. This removes our dependency on Fishhook by inlining the code that we use from it. If Fishhook ends up getting more updates in the future, we can consider re-adding it as a dependency.

Probably easiest to review by commit. The first commit copies in the code from Fishhook and the remaining commits extract out parts of it that we don't need.

NickEntin commented 3 years ago

cc @Sherlouk

Sherlouk commented 3 years ago

Awesome stuff!