cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 69 forks source link

Add iOS 14.2 to snapshot test matrix #52

Closed NickEntin closed 3 years ago

NickEntin commented 3 years ago

Ugh, SnapshotTestingTests.testInvertColors is giving me different results when I step through it with a debugger vs. run it regularly... and neither are correct 🙃

NickEntin commented 3 years ago

Now I'm getting the correct result when I step through it with a debugger (the snapshot I just added), but when it run it normally I still just get an all-black image.

NickEntin commented 3 years ago

I manually compared these snapshot against the demo app, and they all match with a few exceptions:

https://user-images.githubusercontent.com/1857549/103620229-0056cd80-4ee8-11eb-97a7-f971c1ddfb2c.mov

NickEntin commented 3 years ago

I'm removing Travis CI as a required build since it isn't running the .com version right now (the .org version is passing, but will stop working soon). Hopefully we can migrate the iOS 12 tests over to GH Actions with #43.

Merging this now, then I'll add the iOS 14 CI build as a required PR check.