search

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 69 forks source link

Added Identifier to inverted snapshot tests #55

Closed joshmsamuels closed 3 years ago

joshmsamuels commented 3 years ago

closes #51

joshmsamuels commented 3 years ago

@NickEntin here is a draft PR of my fix. The reason for this being a draft is the local inversion of the entire screen instead of just the colours

NickEntin commented 3 years ago

@joshmsamuels I filed #56 to track fixing the flipped image issue

joshmsamuels commented 3 years ago

Thanks! @NickEntin sorry for another ping but do you have any idea why some of the tests are failing? All the snapshots appear to be the same and all the tests pass locally.

It seems really odd that the iOS 12 tests are passing here but 13 & 14 are failing

NickEntin commented 3 years ago

do you have any idea why some of the tests are failing?

@joshmsamuels I'm having trouble reproducing the issue locally. See my comment in #56. Can you test locally and see which path it's taking?