search

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 68 forks source link

Do you want more Localizations? #61

Closed fruitcoder closed 3 years ago

fruitcoder commented 3 years ago

Since I am running my tests in another language than English, the resulting snapshot is mixed-language. Should I add German to Localizable.strings and if so how did you get the Strings for English? Just from experience or do you have a sample app that allows you to extract all the Strings from?

NickEntin commented 3 years ago

Thanks for your interest @fruitcoder! More localizations would be a great improvement to the framework.

All of the strings came from running the demo app with VoiceOver enabled and picking out the words/phrases that VoiceOver uses. For the most part you should be able to pair each screen in the demo app with a snapshot reference image and match the output from VoiceOver with the written description in the snapshots.

fruitcoder commented 3 years ago

Awesome! I'll try to create a PR this week 👍

fruitcoder commented 3 years ago

62

NickEntin commented 3 years ago

I'm going to mark this issue as closed since we've merged in the German localization now. Support for other languages should probably be tracked by individual tickets.