NickEntin
commented
3 years ago I think this functionality is a great addition! But I would actually add this to the existing modules, rather than as a separate subspec. While most of the framework focuses on VoiceOver (as well as covering most of Switch Control), there's already prior art for supporting other features like Invert Colors.
The best approach here is probably to add the filter logic to the core subspec and then create interfaces for using it in tests in the subspecs for the two snapshotting engines.
Sherlouk
Hey Nick 👋
Leaving this as draft, as it's entirely up to you whether you think this is valuable within the scope of this project.
While maybe (for some) not as helpful as the core VoiceOver capability this project offers, colour blindness simulation can still be an important part of some team's accessibility reviews. This is where my project was born from.
Having now validated the capability, I wanted to see what you thought about making this an optional component of this project. Users would have to explicitly opt-in to include this subspec/target in their project, but having accessibility snapshots of all forms under a single umbrella seems like a good vision to have.
Let me know what you think, and as always feel free to decline if you'd rather keep them separate!