search

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 67 forks source link

Remove XCTest as a dependency #69

Closed ra1028 closed 2 years ago

ra1028 commented 2 years ago

Description

Removes XCTest as a dependency of the Core library.

Motivation and Context

I'm using AccessibilitySnapshot through PlaybookAccessibilitySnapshot. (Thanks for mentioning my library in the README before 😄 ). Recently, the increase in testing time to get the snapshots has become an issue. So, since my project uses Bazel as a build system, I am challenging the effort to use a remote cache for the reference snapshots. As a start, Bazel doesn't allow output from test runs as artifacts, so I need to output from the app simulator runtime instead of unit-test. I've already taken care of this in Playbook, but I want to change it so that we can run without XCTest in this library as well because PlaybookAccessibilitySnapshot depends on this library. Apparently, the Core library hasn't actually depended on XCTest, but since it was declared as a dependency, I removed it.

NickEntin commented 2 years ago

Thanks for opening this! You're totally right, after we split the framework into subspecs, there's nothing in the Core spec that actually needs XCTest. This is a great update to make the core framework usable in more places.

Before I merge this, have you signed our CLA?

ra1028 commented 2 years ago

@NickEntin Thanks for taking a look at this. Signed!

NickEntin commented 2 years ago

Awesome, thanks Ryo! Merging this in now and will plan on pushing a new release soon (hopefully this evening).