cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
553 stars 68 forks source link

Data table descriptions are incorrect on iOS 13 and later #7

Open NickEntin opened 4 years ago

NickEntin commented 4 years ago

The accessibility description for elements in a data table appears to have subtly changed on iOS 13. The differences can be seen in the following tests:

testDataTable

The most obvious change here is that the accessibilityValue comes before the row and column numbers. I'm not sure where the "5 of 1" came from.

testDataTableWithHeaders

testDataTableWithUndefinedRows

I think the row number in the first cell is coming from an overflow of NSNotFound + 1. This feels like a regression in VoiceOver, but we should try to match the behavior of VoiceOver in our descriptions as close as possible.

NickEntin commented 4 years ago

Marking this as P1: High Priority based on the missing "Row/Column Header" labels. If we can fix the header labels, I think the rest will be a P2.

NickEntin commented 4 years ago

These changes will apply to iOS 14 as well, potentially with a few more additions.